Ensure we always normalize history before saving #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we normalized history whenever layers were added (either via AddLayer or ReuseLayer), but when rebasing, if the new base image has empty layer history the information about the empty/non-empty aspect of the history will be lost if "preserve history" isn't set on the image. Signed-off-by: Natalie Arellano <narellano@vmware.com>
jjbustamante
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
Great! This fixes a problem with were having on pack with the acceptance tests when bumping to the latest version of lifecycle and imgutil
jabrown85
approved these changes
Apr 22, 2024
natalieparellano
added a commit
to buildpacks/lifecycle
that referenced
this pull request
Apr 22, 2024
Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano
added a commit
to buildpacks/lifecycle
that referenced
this pull request
Apr 22, 2024
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, we were normalizing history whenever layers were added (either via AddLayer or ReuseLayer),
but when rebasing, if the new base image has empty layer history, the information about the empty/non-empty aspect of the history will be lost if "preserve history" isn't set on the image.
Prior to the "v1 refactor" in #257 we were also normalizing history before saving, so this is restoring previous behavior.