WIP: Send dispatch event to buildpacks/samples on lifecycle release #1010
Conversation
The workflow will trigger on published releases of lifecycle. Samples will be rebuilt on receiving dispatch events and updated with the latest lifecycle version. See buildpacks#801 Signed-off-by: glokta1 <rafeyahmad@protonmail.com>
Signed-off-by: glokta1 <rafeyahmad@protonmail.com>
glokta1
force-pushed
the
dispatch-release
branch
from
d8db24e
to
759c104
Compare
| on: | ||
| release: | ||
| types: | ||
| - published |
There was a problem hiding this comment.
Great catch! I do think we want this to be released
|
Thanks for the PR @glokta1! I'll test this out on my fork... |
Co-authored-by: Natalie Arellano <narellano@vmware.com> Signed-off-by: Rafey Ahmad <71697384+glokta1@users.noreply.github.com>
Co-authored-by: Natalie Arellano <narellano@vmware.com> Signed-off-by: Rafey Ahmad <71697384+glokta1@users.noreply.github.com>
|
Looks good to me! @jabrown85 WDYT? |
|
@glokta1 apologies for letting this PR sit here - I think we were waiting for buildpacks/samples#138 to react to the dispatch before merging them together. It looks like buildpacks/samples#138 registers the event but doesn't actually update the builder.toml files or published images. Let us know if you intend on picking that back up, otherwise we might just close both PRs for now. |
|
Hey @natalieparellano, I should apologize for the lack of communication. I encountered some difficulties in setting up the test environment while writing the other workflow and left it at the time. I will pick it back up in a 2-3 days' time :) |
|
Sorry, something unexpectedly came up and I got too much on my plate right now :/. We can close these PR's for now if you want. |
|
No worries, thanks a lot for your effort @glokta1 ❤️ |
Adds workflow to send dispatch event to
buildpacks/sampleson lifecycle releases. This will be used as a trigger on the receiving end to rebuild the samples and update theirbuilder.tomlfiles with the latest lifecycle version.Lifecycle version is sent in dispatch payload.
Resolves #801
Question: Am I correct in thinking the activity type of
releaseshould bereleasedand notpublished? I took it from thepost-release.ymlfile but I presume we want to send the dispatch event only for (stable) releases, not pre-releases or draft releases?