Read /etc/os-release file when distro information is not present in labels
#1347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbusko
force-pushed
the
fix-conditional-os-release-read
branch
from
c0edb70
to
6caf66e
Compare
|
@pbusko thank you for the PR. It looks like some test expectations need to be updated - LMK if you'd like any help with this. |
edmorley
reviewed
Apr 30, 2024
pbusko
force-pushed
the
fix-conditional-os-release-read
branch
4 times, most recently
from
55221fd
to
7afac5a
Compare
|
@natalieparellano unfortunately the unit tests on windows are failing due to unknown to me reasons and I'm unable to debug it on that platform, seems like the change itself included in the PR does not have any effect on windows? |
pbusko
force-pushed
the
fix-conditional-os-release-read
branch
from
7afac5a
to
e052ecc
Compare
… labels Signed-off-by: Pavel Busko <pavel.busko@sap.com>
pbusko
force-pushed
the
fix-conditional-os-release-read
branch
4 times, most recently
from
795b9b4
to
9b8cd1b
Compare
Signed-off-by: Pavel Busko <pavel.busko@sap.com>
pbusko
force-pushed
the
fix-conditional-os-release-read
branch
from
9b8cd1b
to
0fafd09
Compare
Co-authored-by: Natalie Arellano <narellano@vmware.com> Signed-off-by: Pavel Busko <busko.pavel@gmail.com>
Co-authored-by: Natalie Arellano <narellano@vmware.com> Signed-off-by: Pavel Busko <busko.pavel@gmail.com>
natalieparellano
approved these changes
May 6, 2024
natalieparellano
added a commit
that referenced
this pull request
May 10, 2024
…t compat #1347 reads the file when providing target env vars to buildpacks during detect, but we also need to consider this info when deciding whether or not to run detect for the buildpack Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano
added a commit
that referenced
this pull request
May 10, 2024
…t compat (#1352) * Reorder functions in file Signed-off-by: Natalie Arellano <narellano@vmware.com> * Also read distro information from /etc/os-release when checking target compat #1347 reads the file when providing target env vars to buildpacks during detect, but we also need to consider this info when deciding whether or not to run detect for the buildpack Signed-off-by: Natalie Arellano <narellano@vmware.com> * Error if we don't find run image OS during analyze And remove checks for missing OS later in the build, as it should always be there Signed-off-by: Natalie Arellano <narellano@vmware.com> --------- Signed-off-by: Natalie Arellano <narellano@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue: #1336
Release notes
Related
Resolves #1336
Context