Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust exporter App Layer log output #1399

Merged
merged 1 commit into from
Sep 11, 2024

Commits on Sep 11, 2024

  1. Adjust exporter App Layer log output

    The 1/N app layer logs are emitted _after_ the layers have been added. This can sometimes be an expensive operation depending on the layer size and export target.
    
    When trying to understand performance during builds, this wording implies the previous log line before the app layers was responsible for the time between the log lines. Adjusting the wording will make it a bit clearer that the time between the two log lines includes both steps.
    
    Before:
    ```bash
    03:50:00 Adding layer 'buildpacksio/lifecycle:launch.sbom'
    03:51:00 Adding 5/5 app layer(s)
    ````
    
    After:
    ```bash
    03:50:00 Adding layer 'buildpacksio/lifecycle:launch.sbom'
    03:51:00 Added 5/5 app layer(s)
    ````
    
    If we are more interested in going the other direction, where we keep "Adding 1/N app layers" and emitting multiple times or something I'm happy to iterate.
    
    Signed-off-by: Jesse Brown <jabrown85@gmail.com>
    jabrown85 committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    5d2f120 View commit details
    Browse the repository at this point in the history