Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing error connecting to a remote daemon over ssh #1876

Merged
merged 1 commit into from
Aug 26, 2023

Conversation

jjbustamante
Copy link
Member

Summary

This PR just fixes an error connecting with a remote daemon over ssh, the only thing I did was to remove a trailing slash in at this line added by this PR

Before

I managed to reproduce the error

> DOCKER_HOST=ssh://jbustamante@34.29.52.176 /Users/jbustamante/go/src/github.com/buildpacks/pack/out/pack build -p ruby-bundler --builder cnbs/sample-builder:bionic sample-remote-app
ERROR: failed to build: failed to fetch builder image 'index.docker.io/cnbs/sample-builder:bionic': error during connect: Post "http://dummy%2F/v1.38/images/create?fromImage=cnbs%2Fsample-builder&tag=bionic": http: invalid Host header

After

I managed to connect to a remote daemon and execute the build

> DOCKER_HOST=ssh://jbustamante@34.29.52.176 /Users/jbustamante/go/src/github.com/buildpacks/pack/out/pack build -p ruby-bundler --builder cnbs/sample-builder:bionic sample-remote-app
bionic: Pulling from cnbs/sample-builder
Digest: sha256:1fbc7290c4af32a7803c084aa2e7f0b5a24a22bed6e10701791848d54fd27605
Status: Image is up to date for cnbs/sample-builder:bionic
bionic: Pulling from cnbs/sample-stack-run
Digest: sha256:22f6e78d4f4d541279069a191c27614cb3f935a5a1259e662ca5f22a85d1541a
....

Documentation

  • Should this change be documented?
    • Yes, see #___
    • No

Related

Resolves #1870

Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
@jjbustamante jjbustamante requested review from a team as code owners August 25, 2023 19:06
@jjbustamante jjbustamante changed the title fixing error connecting to a remote daemon over ssh Fixing error connecting to a remote daemon over ssh Aug 25, 2023
@github-actions github-actions bot added this to the 0.31.0 milestone Aug 25, 2023
@github-actions github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label Aug 25, 2023
@jjbustamante jjbustamante modified the milestones: 0.31.0, 0.30.1 Aug 25, 2023
@jkutner jkutner merged commit e03ab0b into main Aug 26, 2023
18 checks passed
@jkutner jkutner deleted the bugfix/jjbustamante/issue-1870 branch August 26, 2023 13:11
@jjbustamante jjbustamante added type/bug Issue that reports an unexpected behaviour. and removed type/enhancement Issue that requests a new feature or improvement. labels Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Issue that reports an unexpected behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pack 0.30.0 fails to fetch builder with Docker engine 24.0.5 on remote host over SSH
2 participants