Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding /tmp folder to pack image distribution #1879

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Adding /tmp folder to pack image distribution #1879

merged 2 commits into from
Sep 6, 2023

Conversation

jjbustamante
Copy link
Member

@jjbustamante jjbustamante commented Aug 30, 2023 •
edited
Loading

Summary

After version 0.30.0 we changed the way pack image is built and distributed, see the following PR. /tmp folder was not added and pack commands requires the /tmp folder exists in order to work properly. This PR is adding /tmp folder to the final pack image distribution

Output

Using dive tool, we can see layers for the pack images distribution

Before

Screenshot 2023-08-25 at 9 11 45 AM

After

Screenshot 2023-08-30 at 9 23 09 AM

Documentation

  • Should this change be documented?
    • Yes, see #___
    • No

Related

Resolves #1875
Resolves #1579

@jjbustamante
Adding /tmp folder to pack image distribution
0320ff1 
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
@jjbustamante jjbustamante added type/bug Issue that reports an unexpected behaviour. github_actions Pull requests that update Github_actions code labels Aug 30, 2023
@jjbustamante jjbustamante added this to the 0.30.1 milestone Aug 30, 2023
@github-actions github-actions bot modified the milestones: 0.30.1, 0.31.0 Aug 30, 2023
@jjbustamante jjbustamante marked this pull request as ready for review August 30, 2023 14:35
@jjbustamante jjbustamante requested review from a team as code owners August 30, 2023 14:35
@dlion
Copy link
Member

dlion commented Aug 31, 2023

LGTM

@jkutner jkutner merged commit 549e7b8 into main Sep 6, 2023
17 checks passed
@jkutner jkutner deleted the bugfix/jjbustamante/issue-1875 branch September 6, 2023 13:34
@jjbustamante jjbustamante modified the milestones: 0.31.0, 0.30.1 Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkutner jkutner jkutner approved these changes

Assignees
No one assigned
Labels
github_actions Pull requests that update Github_actions code type/bug Issue that reports an unexpected behaviour.
Projects
None yet
Milestone
0.31.0
Development

Successfully merging this pull request may close these issues.

Pack 0.30.0 fails because of not found /tmp directory Support running pack Docker image on Cloud Build
3 participants
@jjbustamante @dlion @jkutner