Missing test case when handling docker context - continuation of the solution to fix 1759 #1894
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Pack could be executed as a binary in a container that mounts the docker sock, when I did it (testing the development binary to check other ticket) I noticed I was not able to run
pack
. It throws the following error:ERROR: reading configuration file at '/root/.docker': open /root/.docker/config.json: no such file or directory
In this container the
.docker
folder doesn't exists and I was not handling that error correctly. This PR fixes this problem and also handles the case where the.docker
folder exists but theconfig.json
file doesn't, In such cases, pack should keep running with its normal execution.Output
Before
ERROR: reading configuration file at '/root/.docker': open /root/.docker/config.json: no such file or directory
After
No error
Documentation
Related
Resolves #1759