Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing test case when handling docker context - continuation of the solution to fix 1759 #1894

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

jjbustamante
Copy link
Member

Summary

Pack could be executed as a binary in a container that mounts the docker sock, when I did it (testing the development binary to check other ticket) I noticed I was not able to run pack. It throws the following error:

ERROR: reading configuration file at '/root/.docker': open /root/.docker/config.json: no such file or directory

In this container the .docker folder doesn't exists and I was not handling that error correctly. This PR fixes this problem and also handles the case where the .docker folder exists but the config.json file doesn't, In such cases, pack should keep running with its normal execution.

Output

Before

ERROR: reading configuration file at '/root/.docker': open /root/.docker/config.json: no such file or directory

After

No error

Documentation

  • Should this change be documented?
    • Yes, see #___
    • No

Related

Resolves #1759

@jjbustamante jjbustamante requested review from a team as code owners September 7, 2023 16:08
@github-actions github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label Sep 7, 2023
@github-actions github-actions bot added this to the 0.31.0 milestone Sep 7, 2023
@jjbustamante jjbustamante force-pushed the bugfix/jjbustamante/issue-1759-2 branch 2 times, most recently from 5adf765 to 7f859d6 Compare September 7, 2023 16:14
@jjbustamante jjbustamante changed the title Missing test case when handling docker context - continue fix for issue 1759 Missing test case when handling docker context - continuation of the solution to fix 1759 Sep 7, 2023
@jjbustamante jjbustamante modified the milestones: 0.31.0, 0.30.1 Sep 7, 2023
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
@jjbustamante jjbustamante force-pushed the bugfix/jjbustamante/issue-1759-2 branch from 7f859d6 to 5fbee86 Compare September 7, 2023 20:04
@github-actions github-actions bot modified the milestones: 0.30.1, 0.31.0 Sep 7, 2023
@jjbustamante jjbustamante added type/bug Issue that reports an unexpected behaviour. and removed type/enhancement Issue that requests a new feature or improvement. labels Sep 8, 2023
@jjbustamante jjbustamante modified the milestones: 0.31.0, 0.30.1 Sep 8, 2023
@github-actions github-actions bot modified the milestones: 0.30.1, 0.31.0 Sep 12, 2023
@github-actions github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label Sep 12, 2023
@jkutner jkutner merged commit 3b7a55c into main Sep 12, 2023
17 checks passed
@jkutner jkutner deleted the bugfix/jjbustamante/issue-1759-2 branch September 12, 2023 00:59
@jjbustamante jjbustamante modified the milestones: 0.31.0, 0.30.1 Sep 12, 2023
@jjbustamante jjbustamante removed the type/enhancement Issue that requests a new feature or improvement. label Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Issue that reports an unexpected behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support docker desktop on Linux
2 participants