Fix the command parameter to work with Buildpacks API 0.9 #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natalieparellano
approved these changes
Aug 7, 2023
Signed-off-by: Domenico Luciani <dluciani@vmware.com>
dlion
force-pushed
the
fix-sample-app-command
branch
from
02c99cb
to
0f368ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the example we are using Buildpacks API 0.9
https://github.com/buildpacks/samples/blob/main/apps/bash-script/bash-script-buildpack/buildpack.toml#L2 which requires to have a
command = [something]as specified in the spec: https://github.com/buildpacks/spec/blob/buildpack/v0.9/buildpack.md#launchtoml-tomlBut in the builder we have a string instead of an array, causing an error when processed: https://github.com/buildpacks/samples/blob/main/apps/bash-script/bash-script-buildpack/bin/build#L13
This PR just fix that putting the
./app.bator./app.shcommand into an array