-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify inside & outside position alignment #617
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KovalevAndrey
approved these changes
Oct 9, 2023
Comment on lines
+141
to
+145
val value = renderValueFlow.collectAsState() | ||
val boxScope = requireNotNull(LocalBoxScope.current) | ||
with(boxScope) { | ||
this@composed | ||
.align(value.value) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
val value = renderValueFlow.collectAsState() | |
val boxScope = requireNotNull(LocalBoxScope.current) | |
with(boxScope) { | |
this@composed | |
.align(value.value) | |
val value = renderValueFlow.collectAsState() | |
val boxScope by requireNotNull(LocalBoxScope.current) | |
with(boxScope) { | |
this@composed | |
.align(value) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issue
PositionOutside
, meaning we ended up with two classes that could affect alignment: One for inside the container, one for offsetting whole screen distances for scrolling.Problems
.align()
can only be applied once in aModifier
change, only the first one having effectPosition
isn't possible since it already maxed out 4D for its AnimationVector (2 for alignment bias, 2 for relative offset coordinates), a hard limit imposed by Compose.Approach in this PR
PositionOffset
which only takes aDpOffset
PositionInside
andPositionOutside
2+2 alignment bias values into a single propertyPositionAlignment
Migration steps for client code
In any client code
TargetUiState
instances:PositionInside
andPositionOutside
withPositionAlignment
offset
was also used next to alignments, also introduce a new field forPositionOffset
and move the value thereCheck list
CHANGELOG.md
if required.