Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix models normalization in link helper #302

Merged
merged 1 commit into from
Mar 24, 2020
Merged

Fix models normalization in link helper #302

merged 1 commit into from
Mar 24, 2020

Conversation

tstormk
Copy link
Collaborator

@tstormk tstormk commented Mar 20, 2020 •
edited
Loading

The code was normalizing a missing models argument to models: [] meaning the cacheKey for TestLinks created via linkFor was different from the cacheKey for TestLinks created via the test helper.

@tstormk tstormk requested a review from buschtoens March 20, 2020 14:00
@buschtoens
Copy link
Owner

Hm, should we maybe do it the other way around and add the normalization in linkFor? I would prefer keeping [] for no models over undefined.

@buschtoens buschtoens merged commit 2e19c00 into master Mar 24, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-models-normalization branch March 24, 2020 12:02
@buschtoens buschtoens mentioned this pull request Aug 6, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buschtoens buschtoens Awaiting requested review from buschtoens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tstormk @buschtoens