Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/components/link: Add "incomplete model" test #503

Merged
merged 1 commit into from
Jan 27, 2021

Conversation

Turbo87
Copy link
Collaborator

@Turbo87 Turbo87 commented Jan 27, 2021

When a component is only used in subroutes of a route with a dynamic segment then a link in that component does not need to specifically set that dynamic segment. With Ember 3.23 and below such links in rendering tests will be treated just like other links: with an empty href.

@Turbo87 Turbo87 merged commit 79b9ca1 into buschtoens:master Jan 27, 2021
@Turbo87 Turbo87 deleted the incomplete-model branch January 27, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants