Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/link-manager: Fix typo in getLinkParamsFromURL() method name #506

Merged
merged 1 commit into from
Jan 28, 2021

Conversation

Turbo87
Copy link
Collaborator

@Turbo87 Turbo87 commented Jan 27, 2021

a "pram" is something slightly different...... 😂

@Turbo87 Turbo87 added the bug Something isn't working label Jan 27, 2021
Copy link
Owner

@buschtoens buschtoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We consider this a private API change?

@Turbo87
Copy link
Collaborator Author

Turbo87 commented Jan 27, 2021

I consider this a bugfix... 😅

@buschtoens
Copy link
Owner

Hm... Maybe we need to add a deprecated alias method to avoid breaking code that may have come to rely on the incorrect spelling?

@Turbo87 Turbo87 merged commit 07517cf into buschtoens:master Jan 28, 2021
@Turbo87 Turbo87 deleted the typo branch January 28, 2021 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants