Fix Ember 3.24 compatibility #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
force-pushed
the
ember-3.24
branch
2 times, most recently
from
d9b2c79
to
81f09e5
Compare
This assertion is no longer valid because emberjs/ember.js#19080 changed the behavior in Ember.js so that rendering tests can have routing enabled too
Bumps [ember-source](https://github.com/emberjs/ember.js) from 3.23.0-beta.5 to 3.24.1. - [Release notes](https://github.com/emberjs/ember.js/releases) - [Changelog](https://github.com/emberjs/ember.js/blob/master/CHANGELOG.md) - [Commits](emberjs/ember.js@v3.23.0-beta.5...v3.24.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
`canary` stays disabled for now, because the `LinkTo` tests appear to be broken there
buschtoens
approved these changes
Jan 28, 2021
|
Awesome! Thanks a lot. 💚 |
This was referenced Jan 29, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the compatibility with Ember.js 3.24 and above, specifically compatibility with emberjs/ember.js#19080. The two primary changes are:
setupLink()is now allowed to be used even if the router is already set upisRouterInitialized) by looking at thecurrentURLproperty of the router serviceThis PR also re-enables the temporarily disabled CI jobs and adds another explicit one for the 3.24 LTS release.