fix: remove wrapping <div>
#52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This disables the wrapper div that EmberComponent implicitly adds to the DOM
buschtoens
reviewed
May 8, 2019
buschtoens
reviewed
May 8, 2019
buschtoens
reviewed
May 8, 2019
|
🤦♂ That one slipped right past me. Sorry. 😅 Thanks for providing a PR right away! I have some minor suggestions. |
|
@buschtoens should be ok now! Do you want me to squash the install commits? Or are you squashing everything when merging? |
buschtoens
approved these changes
May 8, 2019
buschtoens
reviewed
May 8, 2019
buschtoens
approved these changes
May 8, 2019
buschtoens
pushed a commit
that referenced
this pull request
May 8, 2019
* chore: Install ember-decorators v6.0.0 * fix: Disable the EmberComponent's wrapper element This disables the wrapper div that EmberComponent implicitly adds to the DOM * Revert "chore: Install ember-decorators v6.0.0" This reverts commit 0c96f58. * chore: Install @ember-decorators/component * Move ember-decorators/component to dependencies * purge company specific registry links from the lock file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The switch from sparkles to EmberComponent caused the appearance of wrapper divs.