refactor(test-helpers): [BREAKING] remove link cache #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
force-pushed
the
remove-cache
branch
2 times, most recently
from
0a56c6a
to
c43d23d
Compare
Turbo87
force-pushed
the
remove-cache
branch
from
c43d23d
to
8e371e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The link cache was intended to ensure that calling
createUILink()with the same parameters would return the exact same instance as for earlier calls. The advantages from doing this are very small though and were causing us to need theember-auto-importdependency (forfast-json-stable-stringify), which in turn causes us to not be compatible with Ember.js 4 at the moment. Additionally, #573 made the cache more complicated or not work at all, because passed-in functions/actions can't be serialized to JSON as a cache key.This PR removes the link cache to resolve all of the above issues. As some apps or test suites might be relying on the current behavior, this PR is flagged as "breaking", although it should most likely not break anything for the majority of apps.