Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use __chkstk for aarch64 instead of __rust_probestack. #800

Merged
merged 2 commits into from
Jan 17, 2020
Merged

Use __chkstk for aarch64 instead of __rust_probestack. #800

merged 2 commits into from
Jan 17, 2020

Conversation

pepyakin
Copy link
Contributor

@pepyakin pepyakin commented Jan 10, 2020 •
edited
Loading

Partially addresses #339 as proposed by @ebeasant-arm.

I've checked the patch on aarch64 and can confirm that now it compiles on linux.

peterhuene
peterhuene approved these changes Jan 10, 2020
View reviewed changes
Copy link
Member

@peterhuene peterhuene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me 👍.

crates/jit/src/link.rs Outdated Show resolved Hide resolved
@sunfishcode sunfishcode merged commit 7890fa6 into bytecodealliance:master Jan 17, 2020
@pepyakin pepyakin deleted the fix-aarch64 branch January 17, 2020 11:18
@pepyakin pepyakin mentioned this pull request Feb 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhuene peterhuene peterhuene approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pepyakin @peterhuene @sunfishcode