Couple of improvements to the abi handling code (part 3) #9267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SystemV and WindowsFastcall calling conventions expect the return area pointer as first argument on most archs, while the Tail and Winch calling conventions expect it as last argument on all archs. On arm64 x8 is used as return area pointer register. S390x already handled everything correctly.
|
Redirecting cause I'm a bit stretched thin right now and I saw y'all were discussing this stuff on Zulip. |
cfallin
approved these changes
Sep 17, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-actions
bot
added
cranelift
|
Fixed the bug with windows_fastcall and added a couple of Debug impl improvements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit adds a couple of assertions against misuse of StructReturn. The next two commits are minor cleanups. And the last commit is a partial ABI fix for multi-value returns.
Helps with #9250