1.Resolving the issue of not being able to find the SmithProbeProxy d… #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ue to the class sandbox in Glassfish; 2.In Glassfish, hooking java.io.File can cause the JVM to exit with an exception when adding a WAR file. For now, temporarily disable the hook on java.io.File
yoloyyh
reviewed
Jul 4, 2024
| if(exceptionObject instanceof ClassNotFoundException) { | ||
| String classname = (String) args[1]; | ||
| //SmithLogger.logger.info("processGlassfishClassLoaderfindClass find class:"+classname); | ||
| if (((classname.startsWith("com.security.smith.") || |
There was a problem hiding this comment.
这部分建议单独封装一个函数，后续如果有依赖添加，只需要改一次
| classname.startsWith("rasp.com") || | ||
| classname.startsWith("rasp.javassist"))) | ||
|
|
||
| return (Object)Class.forName(classname); |
| "org.apache.felix.framework.BundleWiringImpl$BundleClassLoader" | ||
| }; | ||
|
|
||
| private Set<String> addedJarset = Collections.synchronizedSet(new HashSet<>()); |
…ing java.io.File will cause the JVM process to crash directly if hooked; 2.It has been tested and passed in GlassFish 5 and GlassFish 7 versions;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ue to the class sandbox in Glassfish;
2.In Glassfish, hooking java.io.File can cause the JVM to exit with an exception when adding a WAR file. For now, temporarily disable the hook on java.io.File
A similar PR may already be submitted!
Please search among the Pull request before creating one.
Thanks for submitting a pull request! Please provide enough information so that others can review your pull request:
For more information, see the
CONTRIBUTINGguide.Summary
This PR fixes/implements the following bugs/features
Explain the motivation for making this change. What existing problem does the pull request solve?
Test plan (required)
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.
Code formatting
Closing issues
Fixes #