feat(parser): support double punctuation in quoted text #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
==========================================
- Coverage 73.96% 73.49% -0.47%
==========================================
Files 20 20
Lines 1540 1543 +3
==========================================
- Hits 1139 1134 -5
- Misses 315 321 +6
- Partials 86 88 +2 |
add a `LIMITATIONS.adoc` file to report limitations or differences with Asciidoc/Asciidoctor when using nested quotes or unbalanced quotes. Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
xcoulon
force-pushed
the
quoted_text_with_double_punctuation
branch
from
e00b7e1
to
e949d34
Compare
xcoulon
added a commit
to xcoulon/libasciidoc
that referenced
this pull request
Feb 24, 2019
With a minor change in the Asciidoctor output: libasciidoc renders single quotes with the `&bytesparadise#39;` HTML entity, which produce the same result in the browser. Fixes bytesparadise#303 Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
xcoulon
added a commit
that referenced
this pull request
Feb 24, 2019
xcoulon
added a commit
to xcoulon/libasciidoc
that referenced
this pull request
May 23, 2020
No need to replace ' and " with &bytesparadise#39; and &bytesparadise#34; Fixes bytesparadise#565 Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
xcoulon
added a commit
that referenced
this pull request
May 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xavier Coulon xcoulon@redhat.com