Add public transport information in waypoints (accesses) listing

[brunobesson]

See #c2corg/c2c_ui#846

Field public_transportation_rating should be included. I assume we do not need the public_transportation_types field.

[AntoineMarnat]

Any progress on this ?

[cbeauchesne]

nope ...

[florentcadot]

Hey!
My understanding is that we should add a public_transportation_rating field in the Route table. It would make sense to also add a field in the Route create/update form front-end side, do you confirm ?

[eddy-geek]

mmm I'm discovering this, but I don't think new columns are needed, instead the existing public_transportation_rating data of the waypoints can be reused?

I'm guessing a route is accessible by public transport if at least one of its linked waypoints is accessible?

[florentcadot]

mmm I'm discovering this, but I don't think new columns are needed, instead the existing public_transportation_rating data of the waypoints can be reused?

I'm guessing a route is accessible by public transport if at least one of its linked waypoints is accessible?

Isola 2000 😍 (a bit of chauvinism, sorry)

@eddy-geek Understood, so does it mean GET /routes should return something like:

{
    "documents": [
        {
            "document_id": 1055792,
            "version": 1,
            "locales": [ ... ],
            "geometry": {...},
            .....
            "areas": [],
            "waypoints": [
            {
                        "document_id": 14274,
                        "version": 11,
                        "locales": [...],
                         "public_transportation_rating": "good service" 
                    },
                        {
                        "document_id": 14275,
                        "version": 11,
                        "locales": [...],
                         "public_transportation_rating": "no service" 
                    },
            ]

?

[Nayor]

Hello !

From my point of view, the needs behind this feature are:

• to know if a route is accessible by public transportation
  directly from the route information, without having to check any waypoints
• to filter routes accessible by public transportation
  with a value comparison, with a slider for instance

I'm not sure giving back all the waypoints is a good way to fulfill these needs.
Moreover, it may increase a lot the response payload.

I've seen that waypoints have a computed value (routes_quantity), maybe routes can have something similar ?
It implies that all routes linked to a waypoint must be updated when the public transportation information is.

Some suggestions:

• main_waypoint_public_transportation_rating (easy to compute, but this point is not necessarily the best for public transportation)
• public_transportation_overall_rating : the best value of all the waypoints (cons: may not be the best start of the route, and can mix up the different transportation types)

[brunobesson]

Sorry, I missed this discussion before answering to the PR made for the frontend.

I made a mistake with the title of the issue. Indeed the idea is to have the public_transportation_rating info on access points, not routes. This is what is missing for c2corg/c2c_ui#846.

Having this information for routes could be interesting too, but it's another subject.

[Nayor]

There is no other issue open about having this information into routes, I think that's a very nice feature to have 🙂

[eddy-geek]

@brunobesson the mistake has been made, now the whole discussion here is about routes, so can we reopen and keep original title?

I like @florentcadot's idea for the API extension, having basic waypoint information on routes (just location+rating, and only for access points) seems to add quite some flexibility, for example to enable better display of the results.