Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable continuous loading of check config #108

Merged
merged 6 commits into from
Feb 19, 2024
Merged

Conversation

lvlcn-t
Copy link
Member

@lvlcn-t lvlcn-t commented Feb 16, 2024

Motivation

Closes #107

Changes

  • fix: validate loader interval
  • feat: get runtime cfg once if interval is zero
  • test: add test cases for the new interval
  • fix: file loader run test race condition

For additional information look at the commits.

Tests done

Provided a new unit test for both loaders.

  • Unit tests succeeded.
  • E2E tests succeeded.

TODO

  • I've assigned this PR to myself
  • I've labeled this PR correctly

* fix: validate loader interval
* feat: get runtime cfg once if interval is zero
* test: add test cases for the new interval
* fix: file loader run test race condition
@lvlcn-t lvlcn-t added bug Something isn't working feature Introduces a new feature area/config Issues/PRs related to the startup/sparrow config area labels Feb 16, 2024
@lvlcn-t lvlcn-t self-assigned this Feb 16, 2024
pkg/config/file.go Show resolved Hide resolved
pkg/config/http.go Show resolved Hide resolved
pkg/config/validate.go Outdated Show resolved Hide resolved
@lvlcn-t lvlcn-t requested a review from y-eight February 19, 2024 10:47
Copy link
Contributor

@y-eight y-eight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Bruno Bressi <bruno.bressi@telekom.de>
Copy link
Member

@puffitos puffitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvlcn-t lvlcn-t merged commit ec148ba into main Feb 19, 2024
11 checks passed
@lvlcn-t lvlcn-t deleted the feat/disable-loader branch February 19, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config Issues/PRs related to the startup/sparrow config area bug Something isn't working feature Introduces a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Panic if loader interval is not set
3 participants