Update sqlparser to 0.34.0

[JanezStupar]

No description provided.

[cachapa]

Is there a strong reason to update this?

[JanezStupar]

The reason is that sql_crdt is holding back other dependencies downstream.

…

On Sun, Feb 4, 2024 at 2:44 PM Daniel Cachapa ***@***.***> wrote: Is there a strong reason to update this? — Reply to this email directly, view it on GitHub <#7 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAE6CFLOXSVHP5B5OGHEAQTYR6GEFAVCNFSM6AAAAABCYV2NCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRVG42TKMJRGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

-- Janez Štupar, www.janezstupar.com

[cachapa]

What other dependencies? Do they need the latest changes in sqlparser?

I'm asking because I have other packages which depend on sql_crdt and there's a cascading effect whenever there are upgrades.
Performing these updates causes some effort on my side and I'd rather avoid it for every version bump in upstream dependencies.

[JanezStupar]

In particular this blocks me and any other user of drift_crdt from upgrading our drift versions.

I do use sql_parser in synchroflite and I did have to change the SetComponent to SingleColumnSetComponent because that was the breaking change in the sql_parser.

FWIW this is upgrade is not a huge deal for me at the moment. Personally I am quite fine with the drift 2.13 that I am working on at the moment. But latest version of drift is 2.15 and while I don't feel the compulsion to stay in lockstep, I feel that not falling too far behind would be a good thing.

It really is up to you - on how much effort that requires in your chain of custody.

On my end this PR requires implementing this PR, doing similar changes in synchroflite - where the changes were actually more involved due to the more extensive use of sql_parser in there. And bumping another package.

I reckon most of the dependency upgrades will only require version bump, but there is a breaking change now and then.

Maybe agreeing to do a periodic version bump is something that would be sustainable for you?

Say every 6 months maybe?

[cachapa]

No, it is fine. If sqlparser includes a breaking change then it makes sense to upgrade early.

Since it doesn't directly affect sqlite_crdt or postgres_crdt I'm happy to release this as a new version.