-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration option to control what host is allowed to use FakeAuth #11
Conversation
that build failure makes no sense - aren't I supposed to target |
"That build failure makes no sense" I like the idea of including a list of hosts, other than local. Much better than an on / off flag. I'm trying to think of scenarios where wild cards would be helpful in this scenario.. or if that opens up FA to too many opportunities for abuse. I'll have time to take look more closely on this later today. |
Fixed the GH action thing too 😉 |
@floyd-may I think this CI build to Nuget was published from the PR, it should only be published when a PR is merged to Develop. 😳 https://www.nuget.org/packages/FakeAuth/1.2.0-ci-61 |
@calebjenkins this ought to be ready to go. Also performed necessary incantations to get the ci actions workflow to only push to NuGet on the Develop branch. |
… obsolete methods
|
||
- name: Pack | ||
run: dotnet pack --configuration Release /p:Version=${{steps.get_version.outputs.RELEASE_VERSION}}-ci-${BUILD_NUMBER} --include-symbols --output . | ||
if: ${{ steps.detect_develop.outcome == 'success' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is beautiful! 🤩🤩 So elegant!
Use case
Building end-to-end testing such that writing e2e tests via Cypress (e.g.) I wouldn't have to instrument logging in via Azure AD, plus I wouldn't have to administer a testing-only AD account (e.g.) in order to validate that my app works correctly when logged in as a certain kind of user. The intent is to control it similar to this so that FakeAuth is only in play when it's needed:
I'll likely use something like
backend
for theFakeAuthHost
setting to match what I've configured in, say, adocker-compose.yml
file.I changed the claims serialization as well so that we can set the claims in a textual way instead of the binary serialization scheme that it was using.
(Fixes #13)