feat: Support passing in literal numbers on uint64 and int64 types #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accepts both string and number when the API expects uint64 or int64. This solution allows regular JS integers (2^53-1) but can also take a string for larger numbers if needed. See googleapis/nodejs-bigquery#1350 for specific discussion on issue.
|
@callmehiphop Hope you can review this PR and googleapis/nodejs-bigquery#1350 for additional discussion. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accepts both string and number when the API expects uint64 or int64.
This solution allows regular JS integers (2^53-1) but can also take a string for larger numbers if needed.
See googleapis/nodejs-bigquery#1350 for specific discussion on issue.