Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repo: Docker setup and pre-merge workflow checks for better CI #15

Closed
5 of 8 tasks
camerondurham opened this issue Jan 26, 2022 · 0 comments · Fixed by #23 or #34
Closed
5 of 8 tasks

Repo: Docker setup and pre-merge workflow checks for better CI #15

camerondurham opened this issue Jan 26, 2022 · 0 comments · Fixed by #23 or #34
Assignees
@camerondurham
Labels
enhancement New feature or request
Milestone
Basic End to End ...

Comments

@camerondurham
Copy link
Owner

camerondurham commented Jan 26, 2022 •
edited
Loading

General repo improvements for faster development.

Merge with confidence! Let Github Actions run tests for you.

Should check the following:

  • build server and CLI binaries successfully
  • passes go lints/vets
  • code coverage test (stretch)

Docker setup for local testing and easier deployment when we decide to do so.

  • add Dockerfiles for running tests
  • Docker compose for running mock server/real server
  • add targets to Makefile for running containers
  • run go ci lint tool

Git Hooks:

  • run go fmt tool on repository before commits
@camerondurham camerondurham self-assigned this Jan 26, 2022
@camerondurham camerondurham mentioned this issue Jan 27, 2022
Open
7 tasks
@camerondurham camerondurham linked a pull request Jan 30, 2022 that will close this issue
Add pre-commit hooks for #15 #23
Merged
camerondurham added a commit that referenced this issue Jan 30, 2022
@camerondurham
Add pre-commit hooks and improve Makefile for #15 (#23)
7e3f320 
* add pre-commit hook script

* add Makefile targets and readme instructions

* add badges to README

* update action options

* verify failing unit test fails action

* fix test

* document the makefile in README
@camerondurham camerondurham reopened this Jan 30, 2022
camerondurham added a commit that referenced this issue Feb 5, 2022
@camerondurham
Add dockerfiles, closes #15
d4eb70f
@camerondurham camerondurham linked a pull request Feb 5, 2022 that will close this issue
Add dockerfiles, closes #15 #34
Merged
@camerondurham camerondurham added the enhancement New feature or request label Feb 5, 2022
camerondurham added a commit that referenced this issue Feb 5, 2022
@camerondurham
Add dockerfiles, closes #15 (#34)
e3f40f3 
* Add dockerfiles, closes #15

* Add docker build action
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@camerondurham camerondurham

Labels
enhancement New feature or request
Projects
401X Runner Project
Status: Done
Milestone
Basic End to End Code Execution API
1 participant
@camerondurham