Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring various v4 recent improvements to next v3 version #1197

Merged
merged 11 commits into from
Jan 6, 2023

Conversation

peaBerberian
Copy link
Collaborator

I worked a lot on our next-v4 branch recently which is the branch for our next v4 major versions.

Some work I have recently done on that branch can also be upstreamed to the v3 releases.
This branch thus adds:

  • API: Stop sending events if the content is stopped due to a side-effect of one of the event handler.
    For example previously, if the application stopped the content during a availableAudioTracksChange event, it was possible to still receive an availableTextTracksChange event after it.
  • API: send available...TracksChange events in the very unlikely scenario where tracks are added after a manifest update (for the same Period for DASH, MetaPlaylist and local contents)
  • Demo: manifest and segment timeouts are now configurable in the demo page
  • Demo: add description to each option, so people can understand what each does
  • Demo: minor fix on the buffer size graph, I'm not sure that the issue seen in the v4 demo is reproducible in the v3 one, but it's still a fix
  • Demo: Remove fake log displayer screen on the bottom of the page, as it doesn't really show anything. If you want logs, open the console
  • tests: fix behavior of one of our memory tests
  • a minor RepresentationStream guard, I'm unsure if this has an effect for the v3 but it is still a safety check.

@peaBerberian peaBerberian added the Performance checks Performance tests are run on this issue / PR label Jan 6, 2023
@peaBerberian peaBerberian added this to the 3.30.0 milestone Jan 6, 2023
@peaBerberian peaBerberian merged commit f3cc462 into next Jan 6, 2023
peaBerberian added a commit that referenced this pull request Jan 31, 2023
…ovements

Bring various v4 recent improvements to next v3 version
peaBerberian added a commit that referenced this pull request Feb 8, 2023
…ovements

Bring various v4 recent improvements to next v3 version
peaBerberian added a commit that referenced this pull request Feb 9, 2023
…ovements

Bring various v4 recent improvements to next v3 version
@peaBerberian peaBerberian mentioned this pull request Feb 21, 2023
@peaBerberian peaBerberian mentioned this pull request Jun 13, 2023
@peaBerberian peaBerberian deleted the misc/bring-v3-compatible-improvements branch July 6, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Performance checks Performance tests are run on this issue / PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant