Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] [v4] Errors: Replace trackInfo prop by tracksInfo to group similar errors #1264

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

peaBerberian
Copy link
Collaborator

@peaBerberian peaBerberian commented Jul 21, 2023

After doing many tests, it seems that the strategy of sending a MANIFEST_INCOMPATIBLE_CODECS_ERROR warning each time we spot an audio or video AdaptationSet with no supported codec in the MPD is not optimal for very large MPD (or equivalent in smooth streaming / local Manifests / MetaPlaylists).

Specifically, MPD with a very large amount of unsupported AdaptationSet (multi-Period MPDs, MPDs with a large choice of AdaptationSet with multiple codecs, dynamic range, audio channels, or all of this together), might produce A LOT of warnings - even more for contents where the Manifest has to be updated.

In turn, those warnings produce a lot of uninteresting warning logs, and might have in some extreme cases a non-null impact on memory as parsing issues were until known stored as a property of the Manifest instance (still less than a MB in the current worst observed cases - so not THAT problematic either, but still).

This PR propose for the v4 the following changes:

  • All MANIFEST_INCOMPATIBLE_CODECS_ERROR warnings seen while parsing a Manifest are regrouped into one - even when talking about media of different types (i.e. "audio" and "video")

  • The trackInfo stored on some MediaErrors is now renamed into tracksInfo (with an s) and is now an Array of tracks - to allow warnings for multiple tracks at once. This is sadly a breaking change - it is relatively minor as trackInfo was optional and a very recent addition - but still, we only authorize ourselves this on the v4 because it is still in beta.

  • A Manifest instance does not "store" the warnings as a property as this is not needed by anything and this is not in the API. This was mainly done because it was the simplest way to implement it - but grouping warnings together now need a more advanced solution anyway.

@peaBerberian peaBerberian merged commit 3b1d382 into next-v4 Aug 23, 2023
3 checks passed
peaBerberian added a commit that referenced this pull request Aug 23, 2023
[Proposal] [v4] Errors: Replace trackInfo prop by tracksInfo to group similar errors
@peaBerberian peaBerberian modified the milestones: 4.0.0, 4.0.0-beta.3 Aug 24, 2023
peaBerberian added a commit that referenced this pull request Aug 31, 2023
[Proposal] [v4] Errors: Replace trackInfo prop by tracksInfo to group similar errors
peaBerberian added a commit that referenced this pull request Aug 31, 2023
[Proposal] [v4] Errors: Replace trackInfo prop by tracksInfo to group similar errors
peaBerberian added a commit that referenced this pull request Aug 31, 2023
[Proposal] [v4] Errors: Replace trackInfo prop by tracksInfo to group similar errors
peaBerberian added a commit that referenced this pull request Sep 15, 2023
[Proposal] [v4] Errors: Replace trackInfo prop by tracksInfo to group similar errors
peaBerberian added a commit that referenced this pull request Sep 15, 2023
[Proposal] [v4] Errors: Replace trackInfo prop by tracksInfo to group similar errors
peaBerberian added a commit that referenced this pull request Sep 22, 2023
[Proposal] [v4] Errors: Replace trackInfo prop by tracksInfo to group similar errors
peaBerberian added a commit that referenced this pull request Sep 26, 2023
[Proposal] [v4] Errors: Replace trackInfo prop by tracksInfo to group similar errors
peaBerberian added a commit that referenced this pull request Sep 26, 2023
[Proposal] [v4] Errors: Replace trackInfo prop by tracksInfo to group similar errors
peaBerberian added a commit that referenced this pull request Sep 27, 2023
[Proposal] [v4] Errors: Replace trackInfo prop by tracksInfo to group similar errors
peaBerberian added a commit that referenced this pull request Sep 27, 2023
[Proposal] [v4] Errors: Replace trackInfo prop by tracksInfo to group similar errors
peaBerberian added a commit that referenced this pull request Sep 27, 2023
[Proposal] [v4] Errors: Replace trackInfo prop by tracksInfo to group similar errors
peaBerberian added a commit that referenced this pull request Sep 29, 2023
[Proposal] [v4] Errors: Replace trackInfo prop by tracksInfo to group similar errors
peaBerberian added a commit that referenced this pull request Oct 13, 2023
[Proposal] [v4] Errors: Replace trackInfo prop by tracksInfo to group similar errors
peaBerberian added a commit that referenced this pull request Oct 13, 2023
[Proposal] [v4] Errors: Replace trackInfo prop by tracksInfo to group similar errors
peaBerberian added a commit that referenced this pull request Oct 13, 2023
[Proposal] [v4] Errors: Replace trackInfo prop by tracksInfo to group similar errors
peaBerberian added a commit that referenced this pull request Oct 19, 2023
[Proposal] [v4] Errors: Replace trackInfo prop by tracksInfo to group similar errors
peaBerberian added a commit that referenced this pull request Oct 26, 2023
[Proposal] [v4] Errors: Replace trackInfo prop by tracksInfo to group similar errors
@peaBerberian peaBerberian deleted the misc/group-codecs-warning branch February 7, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant