[Proposal] "Remove" manifestUpdateUrl loadVideo option for the v4
#1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peaBerberian
added
the
proposal
peaBerberian
force-pushed
the
misc/remove-manifestUpdateUrlDoc
branch
from
0040c31
to
e9445e3
Compare
peaBerberian
force-pushed
the
next-v4
branch
from
fa9ef07
to
a3d16f0
Compare
This commit undocument the `manifestUpdateUrl` API, so it is effictevely not part of the official API anymore, even if its behavior stays for now (renamed as `__priv_manifestUpdateUrl`). The `manifestUpdateUrl` was an advanced DASH optimization where it was possible to update a dynamic MPD through a shorter version of it, thus much faster. This was a clever solution for a real issue we had for a long time at Canal+, but it relied on complex and easy-to-break logic to perform updates. Now, we prefer other solutions, which are either standard (e.g. DASH packaging techniques to reduce the size of the MPD) or purely based on code optimizations (WebAssembly-based parsers, advanced parsing modes) - thus not relying on special URL like it was with this. As It is not needed at Canal+ anymore, it is not standard in any way, we didn't hear of any other person using this feature and as removing it does not break playback (it only make it less efficient if the feature was relied on before), I propose we profit from the v4 still being in beta to remove it before an official v4. Though this commit does not really remove the corresponding logic yet, it only moves it as an undocumented API. This is because we may want to still keep that logic maintained for some months in case its need ever seems to make a comeback.
peaBerberian
force-pushed
the
misc/remove-manifestUpdateUrlDoc
branch
from
e9445e3
to
b1cfcae
Compare
peaBerberian
added a commit
that referenced
this pull request
Sep 22, 2023
[Proposal] "Remove" `manifestUpdateUrl` loadVideo option for the v4
peaBerberian
added a commit
that referenced
this pull request
Sep 26, 2023
As we're going to probably remove it from the v4 (#1276), it makes sense to prepare its removal by first deprecating in the v3.
peaBerberian
added a commit
that referenced
this pull request
Sep 26, 2023
[Proposal] "Remove" `manifestUpdateUrl` loadVideo option for the v4
peaBerberian
added a commit
that referenced
this pull request
Sep 26, 2023
[Proposal] "Remove" `manifestUpdateUrl` loadVideo option for the v4
peaBerberian
added a commit
that referenced
this pull request
Sep 27, 2023
[Proposal] "Remove" `manifestUpdateUrl` loadVideo option for the v4
peaBerberian
added a commit
that referenced
this pull request
Sep 27, 2023
[Proposal] "Remove" `manifestUpdateUrl` loadVideo option for the v4
peaBerberian
added a commit
that referenced
this pull request
Sep 27, 2023
[Proposal] "Remove" `manifestUpdateUrl` loadVideo option for the v4
peaBerberian
added a commit
that referenced
this pull request
Sep 29, 2023
[Proposal] "Remove" `manifestUpdateUrl` loadVideo option for the v4
Merged
peaBerberian
added a commit
that referenced
this pull request
Oct 12, 2023
As we're going to probably remove it from the v4 (#1276), it makes sense to prepare its removal by first deprecating in the v3.
peaBerberian
added a commit
that referenced
this pull request
Oct 13, 2023
[Proposal] "Remove" `manifestUpdateUrl` loadVideo option for the v4
peaBerberian
added a commit
that referenced
this pull request
Oct 13, 2023
[Proposal] "Remove" `manifestUpdateUrl` loadVideo option for the v4
peaBerberian
added a commit
that referenced
this pull request
Oct 13, 2023
[Proposal] "Remove" `manifestUpdateUrl` loadVideo option for the v4
peaBerberian
added a commit
that referenced
this pull request
Oct 19, 2023
[Proposal] "Remove" `manifestUpdateUrl` loadVideo option for the v4
peaBerberian
added a commit
that referenced
this pull request
Oct 26, 2023
[Proposal] "Remove" `manifestUpdateUrl` loadVideo option for the v4
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR un-documents the
manifestUpdateUrlAPI, so it is effectively not part of the official API anymore, even if its behavior stays for now (renamed as__priv_manifestUpdateUrl).The
manifestUpdateUrlwas an advanced DASH optimization where it was possible to update a dynamic MPD through a shorter version of it, thus much faster.This was a clever solution for a real issue we had for a long time at Canal+, but it relied on complex and easy-to-break logic to perform updates.
Now, we prefer other solutions, which are either standard (e.g. DASH packaging techniques to reduce the size of the MPD) or purely based on code optimizations (WebAssembly-based parsers, advanced parsing modes) - thus not relying on special URL like it was with this.
As It is not needed at Canal+ anymore, it is not standard in any way, we didn't hear of any other person using this feature and as removing it does not break playback (it only make it less efficient if the feature was relied on before), I propose we profit from the v4 still being in beta to remove it before an official v4.
Though this PR does not really remove the corresponding logic yet, it only moves it as an undocumented API.
This is because we may want to still keep that logic maintained for some months in case its need ever seems to make a comeback.