Clean-up whole buffer in get_time_ranges_for_content.ts to be safe #1283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When content become undecipherable the RxPlayer first tries to remove
the corresponding data from the buffer. When it is not known when the
corresponding undecipherable data is in the buffer (a normally rare
occurence, but can theoretically happen), it previously removed
everything that is currently known to be buffered.
This code now removes the whole buffer and doesn't limit itself at "what
is known to be buffered" at that particular point in time:
- There may be unfinished push operations still going on (should be
very rare) in which case the data may not be removed in the previous
behavior.
- It simplifies things, especially with the still-on-draft WebWorker
branch (#1272) which may lead to the buffered data not obtainable
synchronously (when MSE run in main thread, as that code would most
likely run in the Worker).
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When content become undecipherable the RxPlayer first tries to remove the corresponding data from the buffer. When it is not known when the corresponding undecipherable data is in the buffer (a normally rare occurence, but can theoretically happen), it previously removed everything that is currently known to be buffered.
This code now removes the whole buffer and doesn't limit itself at "what is known to be buffered" at that particular point in time:
MULTI_THREADfeature relying on a WebWorker #1272) which may lead to the buffered data not obtainable synchronously (when MSE run in main thread, as that code would most likely run in the Worker).