Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix theoretical memory leak on reload in stream PlaybackObserver creation code #1286

Merged
merged 1 commit into from
Sep 26, 2023

Commits on Sep 25, 2023

  1. Fix theoretical memory leak on reload in stream PlaybackObserver crea…

    …tion code
    
    When working on the WebWorker branch (#1272), I noticed a (small) memory leak
    where a created PlaybackObserver could still be running after a reload
    for the same content, whereas it should not.
    
    This removes that leak by ensuring all logic is cleaned-up on each
    reload.
    
    However, we do have memory-leak tests checking for leaks in that area
    and it didn't find anything, running the corresponding test before and after
    the commit is applied seems to result in roughly the same JS heap size.
    We may have to look if the test does not do what we want it to do or if the
    leak in question is very insignifance/does not apply in our current code.
    peaBerberian committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    52890df View commit details
    Browse the repository at this point in the history