[v3] fix: safari support audio lang "und" in audioTrack #1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In HLS with Safari, if the lang "und" (undetermined) is provided in the HLS manifest, safari will set `audioTrack.language` to `""` because "und" does not seems to be recognised as a lang for safari. This commit patch this behavior by changing lang if the lang is "" and label is "und"
Merged
Florent-Bouisset
approved these changes
Jun 13, 2024
|
You're right, I mainly resolved conflicts (due to prettier I guess + minor updates that have been made since there I imagine) but it ended up with only cosmetic diff. However, I do think that having a file more up-to-date with |
Ok seems good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an adaptation of #1428 for our legacy v3 versions, which still get some bug fixes backported from the v4