[Proposal] Add noCheck scripts and use it in our publish_test_package CI script #1553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When debugging an application, we often have to do quick and dirty updates to the RxPlayer code. When doing this, TypeScript's type-checking can get in the way - and what could amount to a few-seconds-update finally can take multiple minutes just to make TypeScript happy. Thankfully, [TypeScript 5.6](https://devblogs.microsoft.com/typescript/announcing-typescript-5-6/), which I just updated the project to, has now a [`--noCheck` option](https://devblogs.microsoft.com/typescript/announcing-typescript-5-6/#the---nocheck-option) allowing to skip type checking. I consequently: - added the `build:noCheck` an `build:dev:noCheck` npm scripts to the `package.json` - added a new `--no-check`/`-n` flag to our `scripts/generate_build.mjs` script - Made our publish_test_package CI script now rely on the `noCheck` variant, as this is mainly used for quick and dirty checks and as another CI check is there for type-checking anyway. There's maybe other places where we could skip checks.
peaBerberian
added
the
proposal
Florent-Bouisset
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When debugging an application, we often have to do quick and dirty updates to the RxPlayer code.
When doing this, TypeScript's type-checking can get in the way - and what could amount to a few-seconds-update finally can take a few minutes just to make TypeScript happy.
Thankfully, TypeScript 5.6, which I just updated the project to, has now a
--noCheckoption allowing to skip type checking.I consequently:
build:noCheckanbuild:dev:noChecknpm scripts to thepackage.json--no-check/-nflag to ourscripts/generate_build.mjsscriptnoCheckvariant, as this is mainly used for quick and dirty checks and as another CI check is there for type-checking anyway.There's maybe other places where we could skip checks.