[Proposal] Add buffer size estimate to debug buffer content graph #1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While continuing proof-of-concepts related to how much buffer we build, I found that our estimate of the current buffer size in bytes (more exactly the combined size of pushed segments that still have at least a sub-part present in the buffer) was a potentially-interesting metric that we did not expose anywhere: neither in logs nor in our DEBUG_ELEMENT feature. This commit adds it to the `DEBUG_ELEMENT` feature, just after the corresponding buffer content graph. It may be even more useful in logs, but I did not bother to do it for now as I currently mainly relied on the debug element.
peaBerberian
added
the
proposal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While continuing proof-of-concepts related to how much buffer we build, I found that our estimate of the current buffer size in bytes (more exactly the combined size of pushed segments that still have at least a sub-part present in the buffer) was a potentially-interesting metric that we did not expose anywhere: neither in logs nor in our DEBUG_ELEMENT feature.
This commit adds it to the
DEBUG_ELEMENTfeature, just after the corresponding buffer content graph.Screenshot: I'm here talking about the
157.711MBfor video appearing at the end ofvbufand1811KBat the end ofabufIt may be even more useful in logs, but I did not bother to do it for now as I currently mainly relied on the debug element.