Fix SourceBuffer.prototype.remove error handling
#1560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed an issue when handling errors from the MSE `SourceBuffer.prototype.remove` API, where our MSE abstraction was emptying all pending operations (`appendBuffer` calls and `remove` calls after that one) yet wasn't also rejecting those other operations' Promise, meaning that the RxPlayer logic wouldn't be notified that those operations were canceled. This may lead to some rare infinite rebuffering.
peaBerberian
added
the
Priority: 0 (Very high)
peaBerberian
added
the
bug
Florent-Bouisset
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed an issue when handling errors from the MSE
SourceBuffer.prototype.removeAPI, where our MSE abstraction was emptying all pending operations (appendBuffercalls andremovecalls after that one) yet wasn't also rejecting those other operations' Promise, meaning that the RxPlayer logic wouldn't be notified that those operations were canceled.This may lead to some rare infinite rebuffering.