Fix bad state on 1st character where model != view #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When first entering text into the field, it's common for the viewValue to be different than the model value. When testing the validity of the current value, the parseViewValue function was checking whether or not the model value was empty, instead of the view value.
…atch-1 Fix bad state on 1st character where model != view
candreoliveira
added a commit
that referenced
this pull request
Aug 30, 2015
Fix bad state on 1st character where model != view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When marking the input as mask-valid or mask-invalid, parseViewValue is checking to see if modelValue is empty, instead of checking to see if the proposed viewValue is empty.
This can cause the field to be marked as valid when the model is currently empty, but the proposed view value is invalid.
I've changed the parseViewValue function to now check that the 'value' from parseViewValue(value) is empty instead of checking the model value.