Stop using explicit \ as directory separator #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 7, 2019 15:12
Modified code to use Path.DirectorySeparator instead of explicit \. Also added new PathEx.FixDirectorySeparator() to make it easier to ensure the correct directory separator is in use. Updated TargetPath property to call PathEx.FixDirectorySeparator whenever it is set. This ensures the directory separator is always correct.
See issue #3
Another commit corrected this for a different issue, but we don't want to perpetuate the incorrect stuff into the main Ketarin project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one includes a single change that's more Linux-specific*. Look at FixDirectorySeparator() in CDBurner/PathEx.cs. It checks which style of directory separator is in use, and changes the opposite one to it. This is really needed on Linux, as someone might be importing configuration from a Windows box (actually, going the other way, this will make it look nicer, although on Windows / will be seen as a directory separator, so it works without). I can easily redo this pull request to remove that coding change if you like, since it's really only needed on Linux.