Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): add craft-parts common documentation #1939

Merged
merged 4 commits into from
Oct 11, 2024

Conversation

lengau
Copy link
Collaborator

@lengau lengau commented Oct 7, 2024

This brings in the common documentation sets from craft-parts and adds some of the pages. It mostly exists to enable my next PR, where I'll document the python and poetry plugins.

@lengau lengau marked this pull request as ready for review October 7, 2024 20:08
Copy link
Contributor

@medubelko medubelko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran into two possible bugs in the implementation. One of them is breaking the build on my end. Let me know what you think.

docs/reference/parts.rst Show resolved Hide resolved
docs/reference/parts.rst Show resolved Hide resolved
@lengau lengau requested a review from medubelko October 9, 2024 14:29
Copy link
Contributor

@medubelko medubelko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build is working on my end now, thanks!

@lengau lengau requested a review from a team October 10, 2024 19:45
Copy link
Contributor

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@lengau lengau added this pull request to the merge queue Oct 11, 2024
Merged via the queue into main with commit 534c028 Oct 11, 2024
23 checks passed
@lengau lengau deleted the work/1913/CRAFT-3425/document branch October 11, 2024 13:27
lengau added a commit that referenced this pull request Oct 17, 2024
This adds documentation for the Python and Poetry plugins.

It builds upon #1939 and
requires canonical/craft-parts#872

NOTE: This still needs a craft-parts update for all docs rendering to
work properly, but please review what you can ITMT

---------

Co-authored-by: Michael DuBelko <michael.dubelko@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants