Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(linter): add 'pip check' linter #1951

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

feat(linter): add 'pip check' linter #1951

wants to merge 17 commits into from
+263 −1

Commits on Oct 9, 2024

  1. feat(linter): add 'pip check' linter 

    This linter runs 'pip check' on the venv of the resulting charm and
warns if the virtual environment is inconsistent.
    @lengau
    lengau committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    4845c12 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. chore: fix ruff warning on subprocess call

    @bepri
    bepri committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    05f2585 View commit details
    Browse the repository at this point in the history

  2. feat: add pip-check to the checkers to be ran

    @bepri
    bepri committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    24d0877 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. chore: autofix remaining ruff warnings

    @bepri
    bepri committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    b48d0e6 View commit details
    Browse the repository at this point in the history

  2. style: format with black

    @bepri
    bepri committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    1692246 View commit details
    Browse the repository at this point in the history

  3. fix: skip pip check linter on windows

    @bepri
    bepri committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    b7fc57b View commit details
    Browse the repository at this point in the history

  4. fix: rearrange internal checks for pip check

    @bepri
    bepri committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    7bbaa57 View commit details
    Browse the repository at this point in the history

  5. fix(linter): skip pip check linter on windows platforms

    @bepri
    bepri committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    3420e24 View commit details
    Browse the repository at this point in the history

  6. fix(linter): apply nonapplicable to pip check on Windows

    @bepri
    bepri committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    1c21ba0 View commit details
    Browse the repository at this point in the history

  7. fix(linter): skip more pip check tests

    @bepri
    bepri committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    fbb9b4f View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. fix(linter): skip pip check linter if charm does not have a valid ven… 

    …v to test
    @bepri
    bepri committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    ff002a3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into work/1889/CRAFT-3369

    @bepri
    bepri committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    7c23dd9 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. chore: PR suggestion

    @bepri
    bepri committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    d01a57a View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. chore: PR feedback

    @bepri
    bepri committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    4423d2d View commit details
    Browse the repository at this point in the history

  2. fix(linter): skip pip check tests on windows

    @bepri
    bepri committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    145428b View commit details
    Browse the repository at this point in the history

  3. Update charmcraft/linters.py 

    Co-authored-by: Callahan <callahan.kovacs@canonical.com>
    @bepri @mr-cal
    bepri and mr-cal authored Oct 17, 2024
    Configuration menu
    Copy the full SHA
    5ac9d2c View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. chore: empty commit to pass CLA CI check

    @bepri
    bepri committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    0e7abd5 View commit details
    Browse the repository at this point in the history