Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple manual cli tests #5784

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

holmanb
Copy link
Member

@holmanb holmanb commented Oct 4, 2024

Proposed Commit Message

Allow calling cloud-init --all-stages for testing purposes.
Also add tests for this behavior and various other CLI commands.

Additional Context

Requires a change in pycloudlib.
We could also check that INFO/DEBUG logs don't show up in command output as well - thoughts?

Test Steps

Check CI integration tests.

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

holmanb added a commit to holmanb/cloud-init that referenced this pull request Oct 4, 2024
holmanb added a commit to holmanb/cloud-init that referenced this pull request Oct 4, 2024
holmanb added a commit to holmanb/cloud-init that referenced this pull request Oct 4, 2024
These quick-check tests check for the following behaviors on PR:
- return code
- unwanted logs in output
Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! Over time, I'd prefer the test go away as each of the commands gets their own test verifying expected output / effects rather than having been run without obvious problems. That'll take time though and better to have broad shallow coverage now.

Should this be a draft PR until we can get the pycloudlib piece?

@holmanb
Copy link
Member Author

holmanb commented Oct 4, 2024

Good idea!

Thanks!

Over time, I'd prefer the test go away as each of the commands gets their own test verifying expected output / effects rather than having been run without obvious problems. That'll take time though and better to have broad shallow coverage now.

+1, no objections

Should this be a draft PR until we can get the pycloudlib piece?

Sure, I just put up the pycloudlib PR, but I'll drop this to a draft until that merges.

@holmanb holmanb marked this pull request as draft October 4, 2024 18:43
holmanb added a commit to holmanb/cloud-init that referenced this pull request Oct 7, 2024
@holmanb holmanb marked this pull request as ready for review October 7, 2024 14:53
Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants