-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple manual cli tests #5784
base: main
Are you sure you want to change the base?
Simple manual cli tests #5784
Conversation
723e723
to
45b805c
Compare
These quick-check tests check for the following behaviors on PR: - return code - unwanted logs in output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea! Over time, I'd prefer the test go away as each of the commands gets their own test verifying expected output / effects rather than having been run without obvious problems. That'll take time though and better to have broad shallow coverage now.
Should this be a draft PR until we can get the pycloudlib piece?
Thanks!
+1, no objections
Sure, I just put up the pycloudlib PR, but I'll drop this to a draft until that merges. |
These quick-check tests check for the following behaviors on PR: - return code - unwanted logs in output
004abc6
to
5097a1c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed Commit Message
Allow calling
cloud-init --all-stages
for testing purposes.Also add tests for this behavior and various other CLI commands.
Additional Context
Requires a change in pycloudlib.
We could also check that INFO/DEBUG logs don't show up in command output as well - thoughts?
Test Steps
Check CI integration tests.
Merge type