Bump libuv version requirement to 1.34 #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cole Miller <cole.miller@canonical.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #617 +/- ##
==========================================
+ Coverage 81.21% 81.23% +0.01%
==========================================
Files 191 191
Lines 27033 27034 +1
Branches 4944 4931 -13
==========================================
+ Hits 21956 21962 +6
+ Misses 3483 3450 -33
- Partials 1594 1622 +28 ☔ View full report in Codecov by Sentry. |
|
I am confused about why codecov doesn't look at the merge commit instead of the tip of the PR branch for comparison purposes. Maybe there's a way to fix that? |
MathieuBordere
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #584
Signed-off-by: Cole Miller cole.miller@canonical.com