github: Test on Ubuntu Noble #654
Conversation
Signed-off-by: Cole Miller <cole.miller@canonical.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #654 +/- ##
==========================================
- Coverage 80.57% 70.72% -9.86%
==========================================
Files 196 195 -1
Lines 28301 26276 -2025
Branches 5300 2820 -2480
==========================================
- Hits 22803 18583 -4220
- Misses 3767 5376 +1609
- Partials 1731 2317 +586 ☔ View full report in Codecov by Sentry. |
Makefile.am
Outdated
| # FIXME this works around an incompatibility between lcov v2 and our copy of ax_code_coverage.m4. | ||
| # Once GNU publishes an updated version of ax_code_coverage.m4 that works out-of-the box with | ||
| # lcov v2, this line should be removed. | ||
| CODE_COVERAGE_LCOV_OPTIONS += --ignore-errors unused |
There was a problem hiding this comment.
I assume these are just warnings and the coverage is still reported correctly, right?
From what I see on the man pages,
unused: the include/exclude/erase/omit/substitute pattern did not match any file pathnames.
so I just want to check we are sure we are not missing any paths.
There was a problem hiding this comment.
Yeah, this was a bad fix. I ended up (2b2982d) just changing CI to only collect coverage on Jammy, so we don't have to deal with the lcov v2 changes at all until GNU publishes an updated ax_code_coverage.m4. (I don't really want to carry our own modified copy, since that creates more work whenever we want to refresh it using changes from GNU.)
I do not think the error reported here is a problem for coverage correctness; it just means that our build doesn't use any files from /tmp, which makes sense. I guess that ax_code_coverage.m4 passes --exclude /tmp/* unconditionally, though I couldn't say confidently why.
There are also some warnings about using an option --lcov-branch-coverage that has been renamed in v2 to just --branch-coverage; again, that's coming straight from our vendored ax_code_coverage.m4, and if we just stick to Jammy until this file can be updated then we should be fine.
Signed-off-by: Cole Miller <cole.miller@canonical.com>
|
Ready to go I think. |
cole-miller
requested review from
letFunny and
just-now
and removed request for
letFunny
Signed-off-by: Cole Miller cole.miller@canonical.com