Add unit and integration tests for kati-ui charm #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Libraries: OK
Libraries: Out of sync
and removed
Libraries: OK
labels
Unit tests cover basic pebble and leader implementation. Integration test checks if charm builds and deploys and that the katib-ui server is coming up. Relates to #5
DnPlas
force-pushed
the
bschimke95-add-katib-ui-tests
branch
from
6bfe6fc
to
31187b3
Compare
github-actions
bot
added
Libraries: OK
Libraries: Out of sync
and removed
Libraries: Out of sync
Libraries: OK
labels
|
Currently CI is failing due to pypa/setuptools_scm#918 |
i-chvets
reviewed
Sep 22, 2023
| harness.cleanup() | ||
|
|
||
|
|
||
| def test_leader(mocker: MockerFixture, harness: Harness[KatibUIOperator]): |
There was a problem hiding this comment.
I would add docstring to each test describing what is being tested.
i-chvets
reviewed
Sep 22, 2023
|
|
||
|
|
||
| @pytest_asyncio.fixture | ||
| async def ws_addresses(ops_test: OpsTest) -> List[str]: |
There was a problem hiding this comment.
I would add doc string that described the purpose of this helper function.
i-chvets
reviewed
Sep 22, 2023
| """Verify that all katib-ui units report ready.""" | ||
| for addr in ws_addresses: | ||
| url = f"http://{addr}:8080/katib" | ||
| home = requests.get(url) |
There was a problem hiding this comment.
Should we wrap this code in try-except? This way, we can assert on any failure in fetching URL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests cover basic pebble and leader implementation. Integration test checks if charm builds and deploys and that the katib-ui server is coming up.
Relates to #5
This is a clone of #141 to be able to see the CI running.