chore: remove mysql relation to drop MariaDB support #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 3, 2024
Merged
orfeas-k
reviewed
Jul 3, 2024
|
the CI is getting stuck at the end of tests execution, I filed #209 to investigate and fix it |
DnPlas
approved these changes
Jul 5, 2024
There was a problem hiding this comment.
Thanks @NohaIhab ! I tested this by deploying the katib-db-manager charm form this PR and tried using the relation juju relate katib-db-manager:mysql <another charm> and I got:
ERROR application "katib-db-manager" has no "mysql" relation
which confirms the relation is not supported anymore.
Then I added the relational-db relation just to ensure that relation was not affected by this change and it works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CKF 1.8 dropped support for MariaDB, which means the charm has to drop all the code that handles this relation.
Summary
mysqlrelation