feat: refactor knative-operator to make adding additional pebble layers easier #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…asier This refactors the knative-operator charm in a way that does not cause any functional change, in order to make it easier to later add another layer to the charm. This should pass existing tests and change no functionality.
Previously, we used the command of the image as the service name in pebble. This refactors to use the name of the application
DnPlas
reviewed
Mar 9, 2023
There was a problem hiding this comment.
Thanks @ca-scribner, this change is already in #82,should we merge this PR and rebase that other one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly a refactor of the naming of functions within the knative-operator, with the goal of making it easier to add additional pebble layers for knative 1.8's webhook. There is a slight functional change here, where we change the pebble service name from the path to the application (
/ko-app/operator) to the application name (knative-operator). Otherwise, this is a non-functional change