Integrate notebook-operators rocks #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misohu
changed the title
DnPlas
approved these changes
Jul 5, 2024
There was a problem hiding this comment.
Thanks @misohu LGTM!
I have done the following to ensure the charms and workloads are working as expected:
Env
microk8s: 1.29-strict/stable
juju: 3.4/stable (3.4.4)
addons: dns hostpath-storage metallb:10.64.140.43-10.64.140.49
Testing steps
- Deploy CKF from latest/edge
juju deploy kubeflow --channel latest/edge --trust - Refresh notebook-operators to this PR
juju refresh jupyter-controller --channel latest/edge/pr-377andjuju refresh jupyter-ui --channel latest/edge/pr-377 - Because
charming-actions/upload-charmaction is uploading images incorrectly and affecting charms' functionality bundle-kubeflow#962 is affecting the release job, I had to manually update the oci-imagejuju refresh jupyter-ui --resource oci-image=charmedkubeflow/jupyter-web-app:1.9.0-0fc426aandjuju refresh jupyter-controller --resource oci-image=charmedkubeflow/notebook-controller:1.9.0-d701af2 - Waited for everything to settle and created some notebook servers from the dashboard
- Works just fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes canonical/kubeflow-rocks#99, canonical/kubeflow-rocks#98
I have changed the images for the new rocks. Tested locally by deploying both charms, without problems.