Merge pull request thephpleague#8 from 1ed/support-php-5.3

Add php-5.3 support
canvaspop · Oct 26, 2015 · 45cd9b5 · 45cd9b5
2 parents 2b8e9b0 + a753ce1
commit 45cd9b5
Show file tree

Hide file tree

Showing 7 changed files with 51 additions and 48 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -1,6 +1,7 @@
 language: php
 
 php:
+  - 5.3
   - 5.4
   - 5.5
   - 5.6

diff --git a/composer.json b/composer.json
@@ -32,7 +32,7 @@
     },
     "require": {
         "omnipay/common": "~2.0",
-        "braintree/braintree_php": "^3.1"
+        "braintree/braintree_php": "^2.0"
     },
     "require-dev": {
         "omnipay/tests": "~2.0"

diff --git a/composer.lock b/composer.lock
diff --git a/src/Message/AuthorizeRequest.php b/src/Message/AuthorizeRequest.php
@@ -15,7 +15,7 @@ public function getData()
     {
         $this->validate('amount');
 
-        $data = [
+        $data = array(
             'amount' => $this->getAmount(),
             'billingAddressId' => $this->getBillingAddressId(),
             'channel' => $this->getChannel(),
@@ -31,7 +31,7 @@ public function getData()
             'shippingAddressId' => $this->getShippingAddressId(),
             'taxAmount' => $this->getTaxAmount(),
             'taxExempt' => $this->getTaxExempt(),
-        ];
+        );
 
         // special validation
         if ($this->getPaymentMethodToken()) {

diff --git a/src/Message/ClientTokenRequest.php b/src/Message/ClientTokenRequest.php
@@ -12,7 +12,7 @@ class ClientTokenRequest extends AbstractRequest
 {
     public function getData()
     {
-        $data = [];
+        $data = array();
         if ($customerId = $this->getCustomerId()) {
             $data['customerId'] = $customerId;
         }

diff --git a/tests/Message/AbstractRequestTest.php b/tests/Message/AbstractRequestTest.php
@@ -38,7 +38,7 @@ public function provideKeepsData(){
             array('privateKey', 'abc123'),
             array('billingAddressId', 'abc123'),
             array('channel', 'abc123'),
-            array('customFields', ['a' => 'b']),
+            array('customFields', array('a' => 'b')),
             array('customerId', 'abc123'),
             array('descriptor', array('a' => 'b')),
             array('deviceData', 'abc123'),
@@ -129,7 +129,7 @@ public function testCardData()
 
     public function testOptionData()
     {
-        $options = [
+        $options = array(
             'addBillingAddressToPaymentMethod' => false,
             'makeDefault'                      => true,
             'failOnDuplicatePaymentMethod'     => true,
@@ -139,7 +139,7 @@ public function testOptionData()
             'storeShippingAddressInVault'      => true,
             'verifyCard'                       => false,
             'verificationMerchantAccountId'    => true,
-        ];
+        );
         $this->request->initialize($options);
         $data = $this->request->getOptionData();
 

diff --git a/tests/Message/AuthorizeRequestTest.php b/tests/Message/AuthorizeRequestTest.php
@@ -23,10 +23,10 @@ public function setUp()
                 'transactionId' => '684',
                 'testMode' => false,
                 'taxExempt' => false,
-                'card' => [
+                'card' => array(
                     'firstName' => 'Kayla',
                     'shippingCompany' => 'League',
-                ]
+                )
             )
         );
     }
@@ -59,10 +59,10 @@ public function testPaymentMethodToken()
                 'transactionId' => '684',
                 'testMode' => false,
                 'taxExempt' => false,
-                'card' => [
+                'card' => array(
                     'firstName' => 'Kayla',
                     'shippingCompany' => 'League',
-                ],
+                ),
                 'paymentMethodToken' => 'fake-token-123'
             )
         );
@@ -80,10 +80,10 @@ public function testPaymentMethodNonce()
                 'transactionId' => '684',
                 'testMode' => false,
                 'taxExempt' => false,
-                'card' => [
+                'card' => array(
                     'firstName' => 'Kayla',
                     'shippingCompany' => 'League',
-                ],
+                ),
                 'paymentMethodNonce' => 'abc123'
             )
         );