-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: bip32 package with blinded xpub support #126
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, nothing to say
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apps/coordinator/src/components/Wallet/TextExtendedPublicKeyImporter.tsx
Outdated
Show resolved
Hide resolved
import { Buffer } from "buffer"; | ||
import crypto from "crypto"; | ||
const DEFAULT_MAX = 2 ** 31 - 1; | ||
export const secureRandomInt = (min = 0, max = DEFAULT_MAX): number => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can enrich types? min: number= 0
etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the type system infers this so intellisense should pick this up just fine (but it is important to be more specific if you want it narrowed down more).
New package for working with bip32 objects. Starting with various utilities for getting blinded xpubs and paths.
Eventually I think it would make sense for a lot of the @caravan/bitcoin keys and paths code to be moved here too.
Diff looks pretty big, but important changes are in packages/bip32 and apps/coordinator
Implemented a proof of concept for support in Caravan Coordinator