Spend to Taproot

[bucko13]

Includes a few fixes:

• don't polyfill process env for trezor environment variables in @caravan/wallets
• cleanup some dependencies in @caravan/wallets
• remove unexported PSBTv0 modules from @caravan/psbt
• work to support bitcoinjs-lib v6 in @caravan/psbt
• Adding support to @caravan/psbt for taproot address outputs

TODO:

• use new tx creation from @caravan/psbt to support paying tr addresses
• new tooling for validateMultisigSignature which extracts the matching public key (?)
• Fix failing tests
• More changesets documenting the changes
• Coordinator should have regtest support
• Might need more robust address validation

NOTE: the diff looks a little bigger than it is because the tiny-secp256k1 library was vendor-ized. See updated readme in @caravan/psbt for more details

[changeset-bot]

🦋 Changeset detected

Latest commit: 24c5c5b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages

Name	Type
@caravan/psbt	Minor
@caravan/bitcoin	Minor
@caravan/wallets	Minor
@caravan/multisig	Major
caravan-coordinator	Minor
@caravan/eslint-config	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
caravan-coordinator	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 6, 2024 7:13pm

[Shadouts]

Code looks good. Comments here are mostly nits. I'm still concerned with the major version increment I commented about on my previous review. Ideally, more changes (many) should be collected and released together as a major increment, or we consider changes to the serialized psbt (a v0-compatible psbt) as not being a breaking change.

[Shadouts]

How long does this take? This line here will initialize ecc when any script runs which imports this module. Is that appropriate? Would it be better to only initialize this inside of a function or class initialization which would be using it?

[bucko13]

that's a good question. I haven't noticed any performance impact and this is the way it's demoed in the bitcoinjs-lib docs. Let me see if initializing in the functions works. It feels clunkier having to do that every time but maybe worth it (and at least in our libs we can abstract that complexity from consumers of caravan).

[bucko13]

I'd like to punt on this now if that's ok. given this is how it's done in the examples it should be ok. But when they hopefully fix some of the other issues with this initialization method, that might be a good opportunity to clean this up, maybe with a singleton factory that can check if it's already initialized.

[bucko13]

I'm still concerned with the major version increment I commented about on my previous review.

@Shadouts version change to caravan/bitcoin converted to minor: 37d46d6

[dylan-thompson]

Spend to taproot works and I haven't found any regressions. Nice work!

A spend to taproot test for the test suite would be nice but not a blocker.