fix issue #321 - load defaults, then localStorage, then url config #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfix22
reviewed
Apr 10, 2018
components/Editor.js
Outdated
| } | ||
| } | ||
| this.setState({ | ||
| ...this.state, |
There was a problem hiding this comment.
You don't need to include this.state in setState (:
There was a problem hiding this comment.
Derp. Haha. Yeah you're right. One sec.
mfix22
approved these changes
Apr 10, 2018
|
@stevensacks thanks so much no idea why I didn't write it like this the first time. Way better. @briandennis see any issues? |
|
Second set of eyes always helps. :) Great tool! Happy to help make it just a little bit better. Now, I want to add Darcula theme (you have Dracula, but Darcula is better, IMO). |
briandennis
approved these changes
Apr 10, 2018
|
Let me know when it's deployed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For IDEs that allow you to open selected code in Carbon, they only pass the language and the code. To avoid losing your localStorage config, the settings should be merged in the following order:
This ensures that all required config is present and that url params trump all.