Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[page descirption tag] need to fix a small spacing issue #1517

Closed
laurenmrice opened this issue Sep 13, 2024 · 0 comments · Fixed by #1519
Closed

[page descirption tag] need to fix a small spacing issue #1517

laurenmrice opened this issue Sep 13, 2024 · 0 comments · Fixed by #1519
Assignees

Comments

@laurenmrice
Copy link
Member

After approving this recent related Gatbsy PR (#1513), I realized that the spacing for this is not entirely correct yet once I saw it actually live in my own PR.

I noticed this because when switching between the Usage/Style/Code/A11y tabs, the height of the description jumps down the page because of the addition of the tag. The page description needs to stay in the same place across tabs even when the tag is present and its not accounting for the space below the tag as part of the full 80px.

Example gif of whats happening in my PR

Sep-13-2024 11-36-43

Spec

What I believe it is not accounting for is including the extra 16px padding below the tag as part of the full 80px.

Screenshot 2024-09-13 at 11 31 42 AM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants